Closed hpoettker closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.16%. Comparing base (
03f8b22
) to head (f3954b8
). Report is 2 commits behind head on master.:exclamation: Current head f3954b8 differs from pull request most recent head cb3f4ee. Consider uploading reports for the commit cb3f4ee to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think there is a difference between waiting for conn.equals(conn.getTransport().getService())
and isKexDone
: the first version also awaits the authentication process to complete, the new solution just waits for the key exchange. I guess it's better to just wait until the auth is done as well, before sending out keep alive messages 🤷
I've added a reproducing test case to StrictKeyExchangeTest
which uses a KeepAlive
that sends heart beats instantantiouly after being started.
I've also relaxed the assertions in StrictKeyExchangeTest
to prevent it from tripping on odd orders in the underlying concurrent processes.
The originally proposed changed should also work. But I've now made a simpler change, i.e. only starting the keep alive thread after the key exchange is done.
Thanks for the PR!
The PR should address #933.