search

hierynomus / sshj

ssh, scp and sftp for java
Apache License 2.0
2.46k stars 594 forks source link

Corrected spelling of ResponseCode No 7 #939

Closed MikeTraceur closed 2 months ago

hierynomus commented 2 months ago

Hi Mike,

Thanks, but since the enum is public and exposed, this is a potentially breaking change and as such I'm not really willing to merge it.

jansohn commented 2 months ago

IMHO not fixing this is the wrong decision. Postponing it for a major release due to a potentially breaking change, OK. But not fixing it at all?

hierynomus commented 2 months ago

Why would you think so? It doesn't change functionality... It's a harmless typo in an enum constant name.

jansohn commented 2 months ago

Well, it's clearly written wrong and it feels sloppy to me when I see such things in code. I mean correcting it might break some users code but it's so easy to fix anyway. But, your library, your decision of course.