Submitting Week 2 Assignment - Coder Chat

[hieunmce]

Here is my completed Week 2 Assignment - CoderChat! /cc @coderschoolreview

[hoksilato]

Hi @HieuNM6, nice work with great submission :+1:

The goals of this homework are:

• to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
• to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
• to build more complex forms in views that involve multiple models.

Quick review:

• Nice UI
• Nice custom routes.
• Good work with helper methods and authentication with before_action for other controllers :100:
• Good work with validations for message.

Some small issues:

• You should publish your facebook app to allow users to login with their FB account. Currently I can't login with my FB account on your Heroku app.

Suggestions

• Should validate email presence and valid email or not in your sign up form.
• Should not allow to add friend/block yourself.

Routes:

• Your used almost default route for messages so that you can remove only from here.
• With routes for sessions, you can define resources :messages, only: [:new, :create, :destroy]

Congrats again on the submission. Everyone has limited time; it's good to see you finished all required and some of optional functionalities. Keep your good work :100: Let us know if you have any feedback.