Submitting Week 1 Assignment - CoderRestaurant

[hieunmce]

Here is my completed Week 1 Assignment - CoderRestaurant!, because I have out of time therefore many feature like validation, relayout, email,... not completed yet. Thanks you. /cc @coderschoolreview

[hoksilato]

Hi @HieuNM6

Thank for your submission :+1:, great job :100:. Good job with the function User can remove item on shopping cart., layout components separating and is_active application helper function.

Here are some of my suggestions:

Overall:

• I think you should move ordering related functions into separating orders_controller.rb, it'll be easier to manage your code.
• Private methods in welcome controller should be in models instead. Because they can be reused and Fat model, thin controller is a proper code structure for MVC.

Another:

• When sorting or filtering by cuisine, you should display the current sorting or filtering value.
• You should display delivery cost in your order page, it's clearer.
• In your welcome#order method, you can use @foods = Food.find(session[:foods_order]), it means: find all foods' info with id is in session[:foods_order].
• I think you forgot something here
• Be careful when naming your variables, it may cause some difficult when read your code in the future. E.g. here, my suggestions, you should use user_order.
• Remember to validate your forms.

Keep up the good work :grinning:

If you have any questions, please let us know by commenting here or email ruby@coderschool.vn.

/cc @coderschoolreview @harley