Finished Assignment 1

[hieupious]

Hi @coderschoolreview I finished Assignment 1. Please help to review it. Thanks

[minhchau273]

:+1: Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Excellent
• Code Style: Excellent
• Visual Design: Average
• Usability: Excellent

Overall: Excellent

Detailed Notes

• Great clean code. Good job utilzing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Nice work implementing the error message on network failure.
• Nice job implementing a UIScrollView. UIScrollView is the parent class of UITableView.
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• It'd be better if you set the icons for the tab bars.

[hieupious]

@minhchau273 thank you so much for a lot of suggestion and detailed comments also. This is the first homework to get me familiar with iOS development. There are still many things need to be improved. To be honest, I'm not good at design but I will try to make the app UI more attractive in these next assignments and the final project as well. About some libraries you suggested, I will apply in next assignment.