hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
870 stars 298 forks source link

Feature request: Handle canceling fingerprint on inscreen fingerprintreaders (Like Samsung S10) #108

Open aaroncornelissen opened 4 years ago

aaroncornelissen commented 4 years ago

I have implemented the react-native-fingerprint-scanner in my application and it works great. I only discovered an event on the Samsung galaxy S10 with a inscreen fingerprintreader (android 9).

If the fingerprintlistner starts the phone shows a popup (see screenshot). But I can't catch or handle the event when the cancel ('Annuleren') button is pressed. Users that want to cancel the fingerprint scanning now have to press cancel twice.

If an error is thrown when a user press cancel I can close my pop-up automatically, but I don't get them.

screenshot

phillbaker commented 4 years ago

@aaroncornelissen very interesting, thanks for sharing.

It seems like on these devices, the best thing would be to not show the FingerprintPopup on android, but to do that, we'd need to know that the device is providing the popup. It might be work looking at https://github.com/anitaa1990/Biometric-Auth-Sample to see if the android sdks provided there can be integrated into this library. I don't have a ton of time to investigate, but happy to review a PR!

aaroncornelissen commented 4 years ago

@phillbaker thanks for your response. I have viewed the example you send, but I am a react-native developer with no Java experience, so I cannot test if it works. When I looked at that example I noticed something. Somewone commented: "In Galaxy S10 there is a biometric screen with a Cancel button. But clicking does not work to cancel the signal to close DialogPrompt", so I don't think this example is the solution.

The link from the comment: https://github.com/anitaa1990/Biometric-Auth-Sample/commit/fc4defaf9ffbca30a8a3fe888543d96406a7360e#commitcomment-33995670