hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
871 stars 297 forks source link

Issues with biometric authentication callbacks on OnePlus 7 Pro devices. #124

Open ghost opened 4 years ago

ghost commented 4 years ago

Failed attempts to authenticate using OnePlus 7 Pro under screen fingerprint scanner do not trigger any error catching functions. Tested on 2 devices, same outcome. Everything works fine on other manufacturer devices. Using following code:

FingerprintScanner.authenticate({ description: 'Authenticate with Biometrics', onAttempt: error => { // NOT CALLED at all }, }) .then(() => { // CALLED if success }) .catch(error => { // NOT CALLED at all });

Library version: 4.0.0 Tested on: 2 OnePlus 7 Pro devices running Android 10

donnes commented 4 years ago

Same here

phillbaker commented 4 years ago

Can you try using a 3.x release?

On Mon, Mar 9, 2020 at 1:06 PM Donald Silveira notifications@github.com wrote:

Same here

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hieuvp/react-native-fingerprint-scanner/issues/124?email_source=notifications&email_token=AAAXCKKY66X5KUZBS6INUSDRGUO2ZA5CNFSM4KSPA4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIEDQQ#issuecomment-596656578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKJ7A4Z4DIHBANYKECLRGUO2ZANCNFSM4KSPA4GQ .

chaitanyadeorukhkar commented 4 years ago

Same problem here. Errors are not being caught on Oneplus 7T either. Can't catch failed attempts and ask for a retry.

Works fine on a Pixel 3 simulator.

Lib version: 4.0.0 RN version: 0.61.5

luukvnes commented 4 years ago

I have the same issue, has anyone found a fix already?

sushant-scalex commented 4 years ago

Facing the same issues on OnePlus 6T, Same code is working on Moto G4+

Lib version: 4.0.0 RN version: 0.61.5

phillbaker commented 4 years ago

What version of android is being used on these devices? This seems to be a widespread issue with the device and OS, not this library: https://forums.oneplus.com/threads/fingerprint-unlock-not-working-on-third-party-apps.1152724/

shubhamverma27 commented 4 years ago

same here

mikehardy commented 4 years ago

@shubhamverma27 did you mean to use a reaction :+1: or similar? Or do you have answers to Phil's question above to move the discussion forward?

shubhamverma27 commented 4 years ago

Sorry, I meant I have the same issue on OnePlus 7 and it seems to be happening with only the new native Android BiometricPrompt lib and works fine in apps which use legacy. For ex. I put a wrong finger on the reader, the reader just disappears without any callback anywhere.

mikehardy commented 4 years ago

@shubhamverma27 there were no software versions mentioned in your comment?

Yuvi7447 commented 4 years ago

@mikehardy Actually, for devices having in-display fingerprint scanner e.g., OnePlus 7T, as @Achilas mentioned error callback does not return anything for invalid fingerprint. As i tested it on OnePlus 7T device, after 5 invalid attempt error callback does work with error response. I tested it with both the below mentioned version. Library version: 3.0.0 Library version: 5.0.0

ghost commented 4 years ago

@Yuvi7447 7 and 7T works correctly for me, 7T PRO and 7 PRO does not.

Yuvi7447 commented 4 years ago

@Achilas Do you get error response for Invalid Fingerprint on every single attempt?

ghost commented 4 years ago

@Yuvi7447 for 7/7T only failure callback, for 7/7T PRO I get no response at all on any error callback.

Yuvi7447 commented 4 years ago

@Achilas Can you pl confirm which lib version you are using, is it 4.0.0? Have you tried out 5.0.0?? Also, can you pl share code snippet for FingerprintScanner.authenticate() method??

shubhamverma27 commented 4 years ago

Hi @mikehardy, I tried both version 4.0.0 and version 5.0.0 and my device is OnePlus 7t. The in-display fingerprint comes up and works fine if I put in the correct one but in case I use a wrong fingerprint then it just disappears without any callback anywhere nor any error. (in just one try) To display it again, I have to re-initialise the call.

Plumito2020 commented 3 years ago

Same here ! Is there any solution ?