search

hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
870 stars 298 forks source link

make setNegativeButtonText configurable #128

Closed soumyamishra89 closed 4 years ago

soumyamishra89 commented 4 years ago

setNegativeButtonText is set to "Cancel" and is not configurable on Android biometrics prompt. I can make a PR for this, if anyone else do not have the time for it.

mikehardy commented 4 years ago

".. should be ..." in open source usually should be re-phrased to "would you mind if I made a PR for .. so it ...", usually about as fast as logging an issue, and with https://github.com/ds300/patch-package you can adopt your change in a safe way immediately while the PR works its way through approval

soumyamishra89 commented 4 years ago

That makes lot of sense. Thank you for the info. I will update accordingly.

phillbaker commented 4 years ago

Fixed in #120