search

hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
871 stars 297 forks source link

Added cancelText to android authenticate #129

Closed soumyamishra89 closed 4 years ago

soumyamishra89 commented 4 years ago

The new biometric prompt on android allows user to use system provided dialog for biometric authentication. The cancel button on that dialog is made configurable by adding cancelText parameter to authenticate method . #128

phillbaker commented 4 years ago

Looks like this is very similar to https://github.com/hieuvp/react-native-fingerprint-scanner/pull/120. What are the benefits of this approach?

soumyamishra89 commented 4 years ago

@phillbaker i did not see there was a merge request already. I added Map to java implementation so that we can send more parameters if required instead of adding parameters to the method signature.

phillbaker commented 4 years ago

Merged https://github.com/hieuvp/react-native-fingerprint-scanner/pull/120. Closing this for now. Please rebase if there are any differences in functionality.