search

hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
870 stars 298 forks source link

fix(android): remove jcenter repository completely #202

Closed matteodanelli closed 2 years ago

matteodanelli commented 2 years ago

Removed jcenter from the android source and from the android example. Replaced jcenter with maven jitpack. Updated flipper and react-native versions to match the latest v0.65.

matteodanelli commented 2 years ago

Done! @mikehardy

mikehardy commented 2 years ago

I pulled the branch and checked it locally, and the example app did not work for android or ios, so it appeared that it had not actually been tested at all @matteodanelli ?

I added three commits which patched up the PR while keeping it minimal, such that the example actually works, for ios and android, and now - with the 3 extra commits verified locally via yarn react-native run-ios and yarn react-native run-android inside the examples directory - this looks good to me

mikehardy commented 2 years ago

Still not sure exactly how to do a release here (though admittedly, I have not even tried, I may not even have permission :laughing: ) @hieuvp - but for anyone that needs this you can use the commit hash of the merge in your package.json in order to get the current version - f1d136f605412d58e4de9e7e155d6f818ba24731

hieuvp commented 2 years ago

Hi @mikehardy, The package was published to npm registry https://www.npmjs.com/package/react-native-fingerprint-scanner Invited you as a maintainer, please check your email, publishing can be done through npm cli.