hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
870 stars 298 forks source link

fix(web): add fallback files in case lib isn't available for a platform #205

Closed hsjoberg closed 2 years ago

hsjoberg commented 2 years ago

This PR will make sure an Error is thrown is case the lib is used on an unsupported platform. Metro would fail to even load the lib if there aren't any fallback files (without android.js etc), which makes it difficult to port apps to different platforms (windows, macos, web etc...).

mikehardy commented 2 years ago

be patient please on release, but in the meantime you may point at the commit hash via github reference I believe?

hsjoberg commented 2 years ago

@mikehardy, no worries on release. I'm already pointing to my own fork like you suggested.