Open anija opened 1 year ago
Oh this one is really important as it the CLI fails the module configuration completely until they release a new version @anija do you think you could post a full PR for this instead of just the patch?
Oh this one is really important as it the CLI fails the module configuration completely until they release a new version @anija do you think you could post a full PR for this instead of just the patch?
I can't do enough test at this moment to feel comfortable in posting a PR :(
That's okay in general I think - you post PR, and CI runs test, or then I have the ability to use github command line tool to easily pull the PR and run tests. No PR? No ability to use tools to do testing etc and integrating a patch for testing is manual process
Flagging a PR like that (like "Hey, I'm posting this but have not had time to test, sorry, hopefully it works or is easier for others to test/verify this way"). It's a human process :-)
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
react-native-fingerprint-scanner@6.0.0
for the project I'm working on.When I upgraded React Native to latest version (0.69.0), i started to see this warning:
warn Package react-native-fingerprint-scanner has been ignored because it contains invalid configuration. Reason: "dependency.assets" is not allowed
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.