search

hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
870 stars 298 forks source link

feature(upgrade): Remove empty react-native.config.js #219

Closed tocalvo closed 1 year ago

tocalvo commented 1 year ago

Hi! The file looks empty but give and error when i try to upgrade to react-native 0.69.3 due to the change on the cli and the deprecated fields hooks and assets.

The react-native-cli update: https://github.com/react-native-community/cli/releases/tag/v8.0.0 and this is the change : https://github.com/react-native-community/cli/pull/1537

I was searching about the reason to add the file with empty values looking in the old cli doc: https://github.com/react-native-community/cli/blob/6615eb30f37bec5bb25acc066c849c4aa2d8a4cd/docs/dependencies.md

But can see any clue about. The fields are empty so seems that can be deleted the whole file.

I try this with my own app. it works, compile without errors and still work the fingerprint scan.

Fixes #243

mikehardy commented 1 year ago

someone just logged an issue about the same thing, I don't have the time to do a release (I'm not really a maintainer here...) but this will at least make a git reference to current code work, thanks!