search

hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
871 stars 296 forks source link

android: remove legacy support #241

Open muelli opened 1 year ago

muelli commented 1 year ago

Legacy support depends on non-free software. That, in turn, prevents other software, which depends on r-n-f-s to become non-free.

https://github.com/hieuvp/react-native-fingerprint-scanner/issues/240

muelli commented 1 year ago

thanks for having a look.

For better or worse, it's not about me, personally. This particular module is preventing apps, Joplin in particular, from being shipped through F-Droid, because this module unconditionally depends on proprietary binaries. I hope you can see that in itself as a bug that deserves fixing.

mikehardy commented 1 year ago

I like F-Droid. I like Fully non-proprietary software, I do agree this is a problem.

However, my comment stands: the minSdkVersion in the react-native ecosystem is 21 in general and your PR moves it to 24 (by removing support for fingerprint readers on popular devices between API21-23). So I don't think it will go in as is.

I recommend using patch-package if F-Droid can handle that (not sure their build system can...) or depending on a fork of your own for this, until minSdkVersion 24 is a reasonable stance for a library

mikehardy commented 1 year ago

Additionally, the PR should probably include the bump to build.gradle's minSdkVersion to 24 and PR title changed to reflect the same - it's aggressive right now but in a year might be perfect, and then it's just a merge...