search

hieuwu / android-groceries-store

A Groceries Store app with basic order flow. 🍕 Help you learn modern Android development skills in real production environment. ❤️
https://hieuwu.github.io/android-groceries-store/
MIT License
220 stars 55 forks source link

Introduce Kotlin lint (detekt) #181

Closed hieuwu closed 12 months ago

hieuwu commented 1 year ago

Is your feature request related to a problem? Please describe. To make the code base to be consistent

Kardelio commented 1 year ago

Ooooo can i grab this issue?

hieuwu commented 1 year ago

Ooooo can i grab this issue?

Sure Kar. Let’s do it

Kardelio commented 1 year ago

Awesome! thank you! So just to be clear its about bring detekt in as a linter. Is there anything more? Like implement into CI/CD or something more?

hieuwu commented 1 year ago

Awesome! thank you! So just to be clear its about bring detekt in as a linter. Is there anything more? Like implement into CI/CD or something more?

Yeah adding it and being able to execute the command to see analyze is good eough. It would be nice if you can implement it into the GitHub action before build step. Many thanks Kar

hieuwu commented 12 months ago

Close as completed in #191