hieuwu / android-groceries-store

A Groceries Store app with basic order flow. 🍕 Help you learn modern Android development skills in real production environment. ❤️
https://hieuwu.github.io/android-groceries-store/
MIT License
231 stars 59 forks source link

Migrated Checkout screen from XML to Compose #189

Closed p42rthicle closed 1 year ago

p42rthicle commented 1 year ago

Migrated Checkout feature to jetpack compose (Fixes #174)

Thing to note:

hieuwu commented 1 year ago

Migrated Checkout feature to jetpack compose (Fixes #174)

Thing to note:

  • Didnt see removeItem, minusItem or plusItem callbacks being implemented anyway even in the viewmodels so those onClick Listeners in LineItemModel item is a TODO

Actually In checkout screen we don't need to implement the minus, plus, click or remove. It's Ok to leave it as is Patt. Great work 👍 Thank you for your contribution

p42rthicle commented 1 year ago

Okay great! No problem Glad to contribute