search

hieuwu / android-groceries-store

A Groceries Store app with basic order flow. 🍕 Help you learn modern Android development skills in real production environment. ❤️
https://hieuwu.github.io/android-groceries-store/
MIT License
220 stars 55 forks source link

False Credentials but it still has a success pop-up #243

Open HoangMinhKhoiPham opened 5 months ago

HoangMinhKhoiPham commented 5 months ago

Describe the bug

When attempting to log in with incorrect credentials on the login page, a success pop-up erroneously appears, indicating successful authentication.

To Reproduce

Steps to reproduce the behavior:

Navigate to the login page. Enter false credentials (invalid username/password combination). Click on the login button. Observe the success pop-up erroneously indicating successful authentication. Expected behavior

Upon entering false credentials, the system should display an error message indicating unsuccessful authentication rather than a success pop-up.

Screenshots

N/A

Desktop (please complete the following information):

N/A

Smartphone (please complete the following information):

N/A

Additional context

This issue poses a significant security risk as it falsely signals successful authentication, potentially granting unauthorized access to the system.

hieuwu commented 5 months ago

Thank you for pointing this out. I’ll add more creential validation to improve this flow