search

hif2k1 / battery_sim

Home assistant home battery simulator - allows you to model how much energy you would save with a home battery
124 stars 14 forks source link

Tariff cost cant add a value that consists of 0,0xxx number #111

Open YOYONL89 opened 9 months ago

YOYONL89 commented 9 months ago

Hello,

When i try to add a Sessy to the simulator i cant add a fixed tariff number which consists of 0,0xxx. When i add a number consisting of 0,xxx it works.

Running Battery_sim 1.3.4 HA: 2024.1.5

hif2k1 commented 9 months ago

This is a bug, but it's not actually a bug with my code. The system that checks data input is called voluptuous and seems to autocorrect 0.0 to 0 before you have time to type the next number. The workaround is to type 0.XX first and then go back and add the second zero after 0.24 -> 0.024. That way it still recognises it as a floating point number and doesn't correct it to zero. I could change it to a free text field, but then you could enter other things like letters that would also break the system. Maybe I will do that on the next release and add my own input verification.

Thanks for flagging up.

On Mon, 29 Jan 2024 at 19:55, YOYONL89 @.***> wrote:

Hello,

When i try to add a Sessy to the simulator i cant add a fixed tariff number which consists of 0,0xxx. When i add a number consisting of 0,xxx it works.

Running Battery_sim 1.3.4 HA: 2024.1.5

— Reply to this email directly, view it on GitHub https://github.com/hif2k1/battery_sim/issues/111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAIZGMB23AK2WC6NZV7NU3YQ75CVAVCNFSM6AAAAABCQA4UR2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYDMMZQGE3DONI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

YOYONL89 commented 9 months ago

Hi hif2k1,

Workaround verified and your correct that works. You want me to close this issue or does it remain open until you decided on what to do in your next release?

hif2k1 commented 9 months ago

Thanks, leave it open please

On Sun, 4 Feb 2024, 13:36 YOYONL89, @.***> wrote:

Hi hif2k1,

Workaround verified and your correct that works. You want me to close this issue or does it remain open until you decided on what to do in your next release?

— Reply to this email directly, view it on GitHub https://github.com/hif2k1/battery_sim/issues/111#issuecomment-1925752439, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAIZGNULSOQ6YS2U3XYP6LYR6FERAVCNFSM6AAAAABCQA4UR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVG42TENBTHE . You are receiving this because you commented.Message ID: @.***>