search

hif2k1 / battery_sim

Home assistant home battery simulator - allows you to model how much energy you would save with a home battery
125 stars 14 forks source link

Optimize device and entity naming #132

Open Bascht74 opened 4 months ago

Bascht74 commented 4 months ago

I think a good addition would be to create devices for each battery. Maybe you could consider this for a future release :-)

Wendelstein7 commented 3 months ago

Isn't this the case already? All my batteries are a 'device' with their entities bundled.

image

Bascht74 commented 3 months ago

Oh, yes! You are right. But only, if you configure via gui... I did via yaml. Changed that!

Bascht74 commented 3 months ago

Changed it. But there is still a bug:

image

the entity names should be "device name entity addition" and not "device name - entity addion". So "Anker Zusatzbatterie 1.6 kWh discharge_only" instead of "Anker Zusatzbatterie 1.6 kWh - discharge_only".

That way it looks much better in the device view:

image

As well the entity addions should not contain an underscore "_":

image

better:

image

And the device name should not integrate the name of the integration:

image

better:

image
hif2k1 commented 3 months ago

Thanks, I will try to sort out the punctuation.

On Sun, 25 Aug 2024 at 13:00, Bascht74 @.***> wrote:

Changed it. But there is still a bug: image.png (view on web) https://github.com/user-attachments/assets/87c9f499-3256-4298-92bc-41ba49076387

the entity names should be "device name entity addition" and not "device name - entity addion". So "Anker Zusatzbatterie 1.6 kWh discharge_only" instead of "Anker Zusatzbatterie 1.6 kWh - discharge_only".

That way it looks much better in the device view: image.png (view on web) https://github.com/user-attachments/assets/d990e5f0-72e3-40e4-ac6c-9bb9c21f5460

As well the entity addions should not contain an underscore "_": image.png (view on web) https://github.com/user-attachments/assets/26eae42d-4520-4f94-8cd2-3b989a43b8a9 better: image.png (view on web) https://github.com/user-attachments/assets/40bcd071-9be7-4bf2-84fb-bada2442d44c

And the device name should not integrate the name of the integration: image.png (view on web) https://github.com/user-attachments/assets/b864e8ef-f2ae-4ff7-9bae-d741128c4d9e

better: image.png (view on web) https://github.com/user-attachments/assets/2cf8f012-be16-43e2-961f-94b453878543

— Reply to this email directly, view it on GitHub https://github.com/hif2k1/battery_sim/issues/132#issuecomment-2308802078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAIZGJNODCIENDRSAW7EULZTHBMHAVCNFSM6AAAAABK3AGTMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYHAYDEMBXHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>