hif2k1 / battery_sim

Home assistant home battery simulator - allows you to model how much energy you would save with a home battery
106 stars 13 forks source link

Clarification for forced charge #56

Closed mdeakin99 closed 1 year ago

mdeakin99 commented 1 year ago

Hi

The battery started a ‘force charge’ last night at 2330 (as normal) but at some point in the night, it filled up (as it does) and then started to discharge.

Does ‘force charge’ stay on until its manually switched off or does it disable after the battery is full?

Is there a way to disable ‘discharge’ until a specific time?

I am trying to replicate charging during cheap rate and not discharging until cheap rate finishes.

hif2k1 commented 1 year ago

It shouldn't start to discharge until the forced charging is disabled by yourself or an automation. There is no mechanism to automatically switch back. Was there a restart at all? I think that would reset it.

If it's a persistent problem let me know and I'll try to fix it.

On Tue, 10 Jan 2023, 09:10 mdeakin99, @.***> wrote:

Hi

The battery started a ‘force charge’ last night at 2330 (as normal) but at some point in the night, it filled up (as it does) and then started to discharge.

Does ‘force charge’ stay on until its manually switched off or does it disable after the battery is full?

Is there a way to disable ‘discharge’ until a specific time?

I am trying to replicate charging during cheap rate and not discharging until cheap rate finishes.

— Reply to this email directly, view it on GitHub https://github.com/hif2k1/battery_sim/issues/56, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAIZGNOGICIWGLLB3JQHELWRURRJANCNFSM6AAAAAATWORK4A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mdeakin99 commented 1 year ago

I think I may have restarted around that time so that’s highly possible.

Thanks… I should have thought about that

On 10 Jan 2023, at 19:18, hif2k1 @.***> wrote:



It shouldn't start to discharge until the forced charging is disabled by yourself or an automation. There is no mechanism to automatically switch back. Was there a restart at all? I think that would reset it.

If it's a persistent problem let me know and I'll try to fix it.

On Tue, 10 Jan 2023, 09:10 mdeakin99, @.***> wrote:

Hi

The battery started a ‘force charge’ last night at 2330 (as normal) but at some point in the night, it filled up (as it does) and then started to discharge.

Does ‘force charge’ stay on until its manually switched off or does it disable after the battery is full?

Is there a way to disable ‘discharge’ until a specific time?

I am trying to replicate charging during cheap rate and not discharging until cheap rate finishes.

— Reply to this email directly, view it on GitHub https://github.com/hif2k1/battery_sim/issues/56, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAIZGNOGICIWGLLB3JQHELWRURRJANCNFSM6AAAAAATWORK4A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://github.com/hif2k1/battery_sim/issues/56#issuecomment-1377733434, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM5C5JZII75IR5DUPQ2A3UDWRWYX7ANCNFSM6AAAAAATWORK4A. You are receiving this because you authored the thread.Message ID: @.***>

hif2k1 commented 1 year ago

Yes would welcome thoughts on this. Not sure if the battery should continue in a override charging or discharging state on a restart or not. HA could have been off for some time and circumstances may have changed so I think it makes sense to rever tot he default state if there is a restart.

mdeakin99 commented 1 year ago

On the assumption that most people are force charging their simulated batteries and that most reboots would be during the day

Either

A) Set it to discharge on reboot. More than likely during the day and this would be the normal state B) if you can, restore to previous state. Only time this wouldn't be right is (I) HA been off for a long time - they battery simulation for this cycle is incomplete anyway (ii) reboot happens during night to day rate shift. Highly unlikely

Just my thoughts on it though :)