search

hifi-finance / hifi-liquidator

Utility for automatically liquidating underwater accounts in Hifi
11 stars 2 forks source link

Handle revert reasons on Kovan #5

Open PaulRBerg opened 3 years ago

PaulRBerg commented 3 years ago

Refer to Do all Ethereum networks return the revert reasons as a “message” field? for a thorough explanation of the issue.

We should modify the Err variant in liquidations.rs so that if the network used is Kovan, the revert reason is decoded from the data field.

PaulRBerg commented 3 years ago

Labelling this as "stale". It's easier to switch to Rinkeby or Goerli for testing purposes and let ethers-rs or the Kovan network itself fix this issue in the future.