search

hifi-finance / hifi

Monorepo implementing the Hifi fixed-rate, fixed-term lending protocol
https://app.hifi.finance
Other
106 stars 15 forks source link

Move errors to a single package #15

Closed PaulRBerg closed 3 years ago

PaulRBerg commented 3 years ago

Errors are currently defined in each respective package, not a package shared by all other packages.

Moving them to a single package would be beneficial due to two reasons:

  1. Centralising errors would make it easier to inspect them when they occur in production.
  2. In certain cases, this would DRY-ify errors. Some @hifi/protocol errors are tested for in other packages.
PaulRBerg commented 3 years ago

Implemented in https://github.com/hifi-finance/hifi/commit/86c84b006a1a21cf6e1e749da9bf56f8017d3e89.