Closed dleonard00 closed 3 years ago
There's a couple of issues introduced by this PR.
deployers
package to something else (e.g. tasks
) or move all the "deployers" to the helpers
package.TASK_ADD_LIQUIDITY
constant is not ordered alphabetically in the constants.ts
fileaddLiquidity.ts
, some of which is not easy to understand at first blush. We should group the code and and add annotations.I will handle these myself.
Further issues:
>=
operator. This is, as far as I know, prone to errors. We should instead use the gt
, gte
, lt
and lte
functions shipped with @ethersproject/bignumber
.*
JavaScript operator. When working with big numbers, we should always use the mul
function shipped with the BigNumber
class.hTokenRatio
is unnecessary, and at any rate doesn't map onto the existing naming system. We call the "ratio" a "scalar".And another big big issue:
The task is calling the HifiProxyTarget
, though that is supposed to be called only via the DSProxy.
There's not an good way to test new workflows. Merging this to be able to test it.