hifi-finance / hifi

Monorepo implementing the Hifi fixed-rate, fixed-term lending protocol
https://app.hifi.finance
Other
106 stars 15 forks source link

[protocol] Use "upgrades.erc1967.getImplementationAddress" to read the implementation address #51

Closed PaulRBerg closed 3 years ago

PaulRBerg commented 3 years ago

Use the newly implemented getImplementationAddress function in the Hardhat plugin to read the implementation address. This is to replace the current workaround to use a locally defined storage slot:

https://github.com/hifi-finance/hifi/blob/e4bb6533f2f62f013003dd9435e92eb031ac7a17/packages/protocol/tasks/deploy/balanceSheet.ts#L33-L35

PaulRBerg commented 3 years ago

Implemented in https://github.com/hifi-finance/hifi/commit/075f9c2177465479aa1048f10a0d1d25bedc3f5e.