I pulled the branch, removed the changes in the protocol/test directory (they cased conflicts with the latest main) and applied the following changes to the Solidity code:
Moved the zero underlying check inside the if (underlyingPrecisionScalar != 1) branch, because that's the only logical branch whereby underlyingPrecisionScalar can be zero.
Renamed the custom error to HToken__RedeemUnderlyingZero, so that it is clearer when it is emitted
I pulled the branch, removed the changes in the
protocol/test
directory (they cased conflicts with the latestmain
) and applied the following changes to the Solidity code:if (underlyingPrecisionScalar != 1)
branch, because that's the only logical branch wherebyunderlyingPrecisionScalar
can be zero.HToken__RedeemUnderlyingZero
, so that it is clearer when it is emitted