hifi-finance / hifi

Monorepo implementing the Hifi fixed-rate, fixed-term lending protocol
https://app.hifi.finance
Other
106 stars 15 forks source link

Add solhint rule to enforce that all interface function implementations should be "override" #89

Open scorpion9979 opened 2 years ago

scorpion9979 commented 2 years ago

In the Hifi monorepo, all the interface function implementations use the "override" modifier. The issue here is that the "override" modifier has been made optional for interface functions since Solidity v0.8.8, and so any implementations that are defined without it would still result in successful compilation.

I think we should not just stick to our current coding style throughout the entire monorepo, but we should also enforce it by enabling the "comprehensive-interface" solhint rule.