search

hifi / heisenbridge

a bouncer-style Matrix IRC bridge
MIT License
241 stars 32 forks source link

Accept elliptic curve keys in the CERTFP command #250

Closed viiru- closed 1 year ago

viiru- commented 1 year ago

Or more correctly stop preventing them from being used. For an EC key the PEM contains -----BEGIN EC PRIVATE KEY----- instead of -----BEGIN PRIVATE KEY----, which wasn't matched by this sanity check. If one wanted to be more specific the -----BEGIN EC PARAMETERS----- section could also be required if EC PRIVATE KEY exists and PRIVATE KEY doesn't, but as this is a trivial sanity check that probably isn't important.

hifi commented 1 year ago

Yeah, this is reasonable. Didn't at the time test EC keys.