search

hifi / heisenbridge

a bouncer-style Matrix IRC bridge
MIT License
241 stars 32 forks source link

Handle new non-numeric sasl events #263

Closed BtbN closed 1 year ago

kepstin commented 1 year ago

Note that I've opened an issue on the irc library: https://github.com/jaraco/irc/issues/214 to inform them about the problem this change caused. I don't really expect any action to come from that; this fix should be merged regardless.

If their policy is that new name mappings for numeric events can be added in minor version bumps, it might be a good idea to also change the dependency in setup.cfg to irc >=19.0.0, <20.4, since there are still a few other numeric codes being used in network_room.py.

hifi commented 1 year ago

I like the cleanup @kepstin suggested. If you could incorporate that I'll happily merge this. Thanks for figuring it out!