search

hifiberry / hifiberry-os

Linux distribution optimized for audio playback
MIT License
958 stars 123 forks source link

Let volume synchronization of snapcast work with Beocreate #522

Closed coen1111 closed 3 months ago

coen1111 commented 3 months ago

In order to let volume sychronization with snapcast work with Beocreate, the alsa volume mixer needs to be changed in snapcastmpris. This was provided via #https://github.com/hifiberry/snapcastmpris/pull/12. In order to provide the alsa mixer name automatically, the /etc/hifiberry.state variable $CURRENT_MIXER_CONTROL can be provided to the service. This has been added with this pull request. Also, you can now enable the volume sychronization of snapcastmpris via the configuration file. A default of sync-alsa-volume = 0 has been added. Additionally the alsa volume mixer can be provided via the configuration file too.

hifiberry commented 3 months ago

Looks like there are some other changes in your PR. Please make sure the PR is based on the "development" branch.

My guess is that you wanted to include only the 2 files snapcastmpris.conf and snapcastmpris.service

Is this correct? In this case I can just do the changes locally.

coen1111 commented 3 months ago

I based the changes on master. So the other commits came along...

But you are right, I only want to change those 2 files, so you can change those locally too.

hifiberry commented 3 months ago

Here we are: https://github.com/hifiberry/hifiberry-os/commit/34040810f5bffe64e6e8643f671bbcd719b0817b