hifis-net / ansible-collection-toolkit

This Ansible collection provides production-ready Ansible roles used for providing services used in research and by research software engineers, but not exclusively.
https://galaxy.ansible.com/hifis/toolkit/
Other
97 stars 22 forks source link

`unattended_dl_limit` doesn't work #76

Closed Encephala closed 1 year ago

Encephala commented 1 year ago

I have passed unattended_dl_limit: 40000 to the role:

- name: Set Unattended upgrades
  ansible.builtin.import_role:
    name: hifis.unattended_upgrades
  vars:
    unattended_dl_limit: 40000
  when: ansible_facts['os_family'] == 'Debian'

But after running the playbook successfully, the change is not made in the 50unattended-upgrades file on the destination:

// Use apt bandwidth limit feature, this example limits the download
// speed to 70kb/sec
//Acquire::http::Dl-Limit "70";

Looking at the defaults for the role, I noticed that unattended_dl_limit is commented out (see below), so perhaps you are already aware of this, but I can't find any mention of it in the repo's README, so I figured I'd share anyways to be sure :)

# Use apt bandwidth limit feature, this example limits the download speed to 70kb/sec
#unattended_dl_limit: 70

I would love if this feature were implemented again!

Encephala commented 1 year ago

Never mind, I just noticed the 90-ansible-unattended-upgrades file.