search

hifis-net / ansible-role-gitlab-runner

:warning: PLEASE NOTE: This role has been migrated to our hifis.toolkit collection. :warning: Ansible role for deploying GitLab-Runner. The role is optimized for use with Openstack.
https://galaxy.ansible.com/ui/repo/published/hifis/toolkit/
Other
8 stars 2 forks source link

Use molecule-podman instead of molecule-docker #37

Closed tobiashuste closed 2 years ago

tobiashuste commented 2 years ago

This will help us to keep the tests running even on systems that have cgroupsv2 enabled. Docker is known to cause problems in combination with systemd inside docker in this case

Closes #36

tobiashuste commented 2 years ago

@Normo and @christianhueserhzdr I'm mentioning you both as reviewer. This is a quite big change which would be introduced in our roles. So I would be curious on your feedback.

tobiashuste commented 2 years ago

@Normo This is how I would suggest to implement the test basing on Molecule. Could you please review?

tobiashuste commented 2 years ago

@christianhueserhzdr You force-pushed to this branch and thereby removed commit and changes? Is there any reason for this?

christianhueserhzdr commented 2 years ago

@christianhueserhzdr You force-pushed to this branch and thereby removed commit and changes? Is there any reason for this?

Tobias @tobiashuste, I am very sorry. I did not realized that I removed something. I had to rebase the branch to add the changes from main and had to resolve conflicts. What did I remove?

tobiashuste commented 2 years ago

@christianhueserhzdr You force-pushed to this branch and thereby removed commit and changes? Is there any reason for this?

Tobias @tobiashuste, I am very sorry. I did not realized that I removed something. I had to rebase the branch to add the changes from main and had to resolve conflicts. What did I remove?

Thanks for the info. I will try to recover from my local version. Typically, I guess it's the better workflow, especially for more complex changes, if the author rebases themself.

tobiashuste commented 2 years ago

I was able to recover my changes :tada:

christianhueserhzdr commented 2 years ago

I was able to recover my changes tada

Phew, I am glad to hear that.