search

higan-emu / higan

higan is a multi-system emulator focused on accuracy, preservation, and configurability.
Other
1.19k stars 112 forks source link

higan-ui: Improvements to input mapper behavior. #140

Closed jchv closed 4 years ago

jchv commented 4 years ago

Input mapper has various peculiar behaviors. It has the same bug that bsnes had that allowed the 'assign...' text to become stale. In addition in Higan, there are various cases where the assign text can get cleared while an active assignment is still being made.

The mouse buttons at the bottom update the same way that they assign, which prevents the bsnes crash and impossible mappings. However, the buttons still do not make any sense because they only display after double clicking but apply to the row that's selected.

This patch ensures only the list item that is selected is updated instead, and also fixes stale 'assign...' text.

Before After
Animation displaying several input bugs as described above. Animation showing the inability to reproduce the bugs described above.
Screwtapello commented 4 years ago

Sorry it's taken such a long time to review this PR, but thank you for submitting it!