search

higgsjs / Higgs

Higgs JavaScript Virtual Machine
875 stars 62 forks source link

fix comparision of X86Opnd #177

Closed MartinNowak closed 9 years ago

MartinNowak commented 9 years ago
maximecb commented 9 years ago

Don't structs without opEquals just do a direct memory comparison?

MartinNowak commented 9 years ago

Don't structs without opEquals just do a direct memory comparison?

They do by field comparison which can optimized to memcmp sometimes. The problem here is that depending on which union member is used, you need to compare more or less memory as the rest isn't cleared on assignment/initialization. https://issues.dlang.org/show_bug.cgi?id=13952