search

higgsjs / Higgs

Higgs JavaScript Virtual Machine
875 stars 62 forks source link

update dmd depecated module names/locatons #208

Closed bFraley closed 8 years ago

bFraley commented 8 years ago

This PR eliminates all deprecated module warnings except for the one related to currAppTick.

@maximecb I left work on MonoTime out of this PR. I think it's a good idea to introduce the new timing functionality under a new Issue/PR in order to more distinctly isolate those changes.

I had one concern over where I added import stats to ir/ast.d This is to eliminate:

ir/ast.d(360): Deprecation: runtime.vm.stats is not visible from module ast

where the line 360 above increments numFunsComp:

stats.numFunsComp++
maximecb commented 8 years ago

Good work.

Nitpick: I would put import stats below all the import std.*. Also core.std.** goes before std.*. I usually sort my imports by low-level to high-level, which is completely arbitrary (lol).

I think you did the right thing in ast.d.

maximecb commented 8 years ago

Merged this PR right away because people might be trying to clone Higgs shortly (might have tried yesterday in fact).

bFraley commented 8 years ago

I'll go back in do the imports how you'd like...I'm picky too, and agree with your way - and keeping things uniform :) @maximecb Can you verify that when building you only get the single warning now, the one for currAppTick?

maximecb commented 8 years ago

I unfortunately don't have access to my home machine here, so I can't test anything until next week.