search

highb / pathspec-ruby

Match Path Specifications, such as .gitignore, in Ruby!
Apache License 2.0
23 stars 9 forks source link

Fix regexp: Match A-Z, not A-z #16

Closed incase closed 6 years ago

incase commented 7 years ago

The regexp is otherwise overmatching, ASCII (and UTF) has many characters between Z and a which are currently also matched: ^ and _ for example.

codecov-io commented 7 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           6        6           
  Lines         364      364           
=======================================
  Hits          363      363           
  Misses          1        1
Impacted Files Coverage Δ
lib/pathspec.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98880f5...92e563a. Read the comment docs.

highb commented 6 years ago

👍 Thanks for the fix!