search

highbyte / sonarscan-dotnet

GitHub Action SonarCloud/SonarQube scanner for .NET 8/7/6/5 and .NET Core applications with pull request decoration support
https://github.com/marketplace/actions/sonarscan-dotnet
MIT License
36 stars 24 forks source link

Option to run action as a Docker image #22

Closed rafaelschlatter closed 11 months ago

rafaelschlatter commented 12 months ago

Hi @highbyte

What do you think of providing this action as a prebuild Docker image? I saw you have started on a GitHub action to create and publish a Docker image to a registry, but currently the action.yml points to the Dockerfile in the "runs" section.

Our experience is that building version 2.2.3 adds about 2 minutes to the run time of our GitHub actions. Using a prebuild version would be nice in order to save some build minutes.

highbyte commented 12 months ago

Hi, Thanks for the feedback. It sounds like something that would be a good idea to implement, I'll look into it.

highbyte commented 11 months ago

@rafaelschlatter There is now a pre-release version highbyte/sonarscan-dotnet@v2.2.4-beta with a pre-built docker image. In my own workflows I've observed that the time for downloading the pre-built image is approx. half the time it took for building it (35 vs 77 seconds). Definitely a worthwhile change.

rafaelschlatter commented 11 months ago

@rafaelschlatter There is now a pre-release version highbyte/sonarscan-dotnet@v2.2.4-beta with a pre-built docker image. In my own workflows I've observed that the time for downloading the pre-built image is approx. half the time it took for building it (35 vs 77 seconds). Definitely a worthwhile change.

@highbyte in our first usages we saw a reduction of ca 90 secs (ca 2 min for building, vs ca 30 secs for pulling). Very much appreciated!

highbyte commented 11 months ago

@rafaelschlatter Thanks for the perf tip! Release version published as highbyte/sonarscan-dotnet@v2.2.4 (no changes from beta)