highbyte / sonarscan-dotnet

GitHub Action SonarCloud/SonarQube scanner for .NET 8/7/6/5 and .NET Core applications with pull request decoration support
https://github.com/marketplace/actions/sonarscan-dotnet
MIT License
36 stars 24 forks source link

outdated way of installing node #24

Closed dssladamjenkins closed 11 months ago

dssladamjenkins commented 11 months ago

We are currently getting a 60 second delay when using this action due to the way node is installed.

They suggest using the following as the current method is going to be removed in future releases.

9 [5/9] RUN curl -fsSL https://deb.nodesource.com/setup_19.x | bash - && apt-get install -y nodejs

9 0.330

9 0.330 ================================================================================

9 0.330 ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓

9 0.330 ================================================================================

9 0.330

9 0.330 SCRIPT DEPRECATION WARNING

9 0.330

9 0.330

9 0.330 This script, located at https://deb.nodesource.com/setup_X, used to

9 0.330 install Node.js is deprecated now and will eventually be made inactive.

9 0.330

9 0.330 Please visit the NodeSource distributions Github and follow the

9 0.330 instructions to migrate your repo.

9 0.330 https://github.com/nodesource/distributions

9 0.330

9 0.330 The NodeSource Node.js Linux distributions GitHub repository contains

9 0.330 information about which versions of Node.js and which Linux distributions

9 0.330 are supported and how to install it.

9 0.330 https://github.com/nodesource/distributions

9 0.330

9 0.330

9 0.330 SCRIPT DEPRECATION WARNING

9 0.330

9 0.330 ================================================================================

9 0.330 ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓

9 0.330 ================================================================================

highbyte commented 11 months ago

Thanks for the feedback. Updating the Node version and how it's installed is on my radar.

If you update your workflow to the use latest version of this action (v2.2.4), it should reduce your workflow time. It has started to use a pre-built Docker image. So there won't be any time spent in each run for building the image (installing sonarscanner, Node, etc), only pulling a pre-built one.