search

highcharts-for-python / highcharts-stock

Python wrapper for the Highcharts Stock data visualization library.
https://stock-docs.highchartspython.com
Other
25 stars 3 forks source link

Add support for `text` field in FlagData #58

Closed szemek closed 5 months ago

szemek commented 6 months ago

Hello, while browsing some highcharts stock demos I found https://www.highcharts.com/demo/stock/flags-general

image

I tried to implement similar chart in Python, but it looks like text field is not supported yet. This pull request add that kind of support.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.79%. Comparing base (cd2b3bf) to head (db93f9e). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ======================================= Coverage 92.78% 92.79% ======================================= Files 285 285 Lines 11670 11680 +10 Branches 433 434 +1 ======================================= + Hits 10828 10838 +10 Misses 699 699 Partials 143 143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

szemek commented 5 months ago

cc @hcpchris

hcpchris commented 5 months ago

Great catch, @szemek ! Thanks. I'll be incorporating this into the v.1.6.0 release that will be going out this weekend.