Opening new tab for download is not necessary

highcharts / export-csv

Highcharts plugin to export chart data to CSV

http://www.highcharts.com/plugin-registry/single/7/Export-CSV

MIT License

76 stars 95 forks source link

Opening new tab for download is not necessary #127

Closed eguitarz closed 7 years ago

eguitarz commented 7 years ago

In Safari 10.1, target="_blank" won't make the browser download the file, instead, it opens the file in a new tab. I don't see any reason to include this target="_blank" with download attribute. So proposing to remove it.

cantsin commented 7 years ago

Oh, nice, I ran into this problem for Safari 10.1 too.

TorsteinHonsi commented 7 years ago

@oysteinmoseng We're on the main repo now: https://github.com/highcharts/highcharts/commit/ff5d200e25bc8751669a8d4ec2384c7377612106

oysteinmoseng commented 7 years ago

@TorsteinHonsi Yes, I realized after merging, and added a commit there as well https://github.com/highcharts/highcharts/commit/b22a5d13867d661b3f4f67060707257e0300e83d. Oh well, can never have too many commits.