search

highcharts / highcharts-editor

https://www.highcharts.com/products/highcharts-editor
Other
250 stars 96 forks source link

path to local assets fix #67

Closed daemth closed 8 years ago

cvasseng commented 8 years ago

Hi daemth,

Thank you for your contribution!

The modified script (res/standalone.html) is used when baking the standalone distribution, where it'll end up in a zip archive along with highcharts-editor.min.css and highcharts-editor.min.js. It's not intended to be used directly. So the path is correct as it is for its intended purpose.

If you want to run the editor locally without using the bundled node server (bin/www) or if you want to run it locally with minified files, please run gulp and then unpack dist/bundles/highcharts-editor.standalone.x.y.z.zip.

I will alter the build script to also move res/standalone.html to dist/ when gulping to make this less confusing.

Thanks, Chris

daemth commented 8 years ago

Hi Cvasseng,

I'm sorry for this request. Just after submitting it I found out about the bundled node server. I guess I was a little too enthusiastic ;-) Thanks a lot for coming back to me and keep up the good work!

Kind regards, Thomas

cvasseng commented 8 years ago

No worries - I'm just happy to see people check out the editor and take the time to submit pull requests. :) And you did uncover an area of potential confusion!

Thanks, Chris