search

highcharts / highcharts-editor

https://www.highcharts.com/products/highcharts-editor
Other
250 stars 96 forks source link

Modal wont close. #79

Closed VictorioBerra closed 7 years ago

VictorioBerra commented 8 years ago

I wish I could provide a fiddle but since the assets are zipped and not hosted on a CDN I cant do that yet. I am also inside an AngularJS app if that matters.

Chrome - Version 54.0.2840.99 m (64-bit) highed - v0.1.1-beta

highed.ModalEditor(document.body, {
    features: 'customize done'
});
cvasseng commented 8 years ago

Hi, are you getting any errors in the chrome console when trying to close it?

VictorioBerra commented 8 years ago

No errors in the console. If you grab my index page from my other issue you might be able to easily replicate this. Download the beta zip and put the index page in it and run it.

On Dec 3, 2016 9:05 AM, "cvasseng" notifications@github.com wrote:

Hi, are you getting any errors in the chrome console when trying to close it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/highcharts/highcharts-editor/issues/79#issuecomment-264644369, or mute the thread https://github.com/notifications/unsubscribe-auth/ACzG6-lK8J0DbMEYC1uh-Ha7wU-OXZ6Mks5rEYUbgaJpZM4LCqzy .

cvasseng commented 7 years ago

Hi, the first argument to highed.ModalEditor is the node which should summon the editor - not the target for the editor itself. See docs here.

Try:

highed.ModalEditor('my-button', {
    ...
});

Instead, where 'my-button' is the id of the button that should spawn the modal editor. There's no need to add additional event listeners on the button, the modal editor does that for you.