highcharts / highcharts-ios

iOS wrapper for Highcharts.
Other
127 stars 39 forks source link

Invalid Privacy Manifest File #434

Closed jobinsjohn closed 6 months ago

jobinsjohn commented 8 months ago
Screenshot 2024-03-20 at 8 44 10 AM

I got the above message from Apple when i submitted the latest version of my App. I am using version 11.4.0 in my latest release.

ihnatmoisieiev commented 8 months ago

Hello @jobinsjohn, thanks for the reporting. I hope it will be fixed next release.

ihnatmoisieiev commented 7 months ago

Hello @jobinsjohn, v11.4.1 has been released. Please check and close the issue if everything is good. Thank you.

7-plus-t commented 7 months ago

Hi @ihnatmoisieiev

Sadly, the privacy manifest is still invalid: Missing an expected key: 'NSPrivacyCollectedDataTypes'

You can verify it by adding the SDK to any app, archive the app and then in the Xcode Organizer ctrl-right click the archive and select "Generate Privacy Report".

As far as I understand the requirements, all 4 keys need to be defined in the file, even if there are no values to be declared:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>NSPrivacyTrackingDomains</key>
    <array/>
    <key>NSPrivacyTracking</key>
    <false/>
    <key>NSPrivacyCollectedDataTypes</key>
    <array/>
    <key>NSPrivacyAccessedAPITypes</key>
    <array/>
</dict>
</plist>

Cheers

ihnatmoisieiev commented 7 months ago

Hello @7-plus-t, thanks for your attention. The issue is fixed and the correct Privacy Manifest file will be available starting the next release.

MikolajMichalczak commented 6 months ago

Hi all! We've just released a new version (11.4.1.1) which addresses this issue. Your feedback is greatly appreciated.

7-plus-t commented 6 months ago

Hi @MikolajMichalczak I can confirm that with version 11.4.1.1 the privacy manifest passes the Xcode checks.

FYI: SPMs allow only three-integer version numbers (e.g. 11.4.2, not 11.4.1.1) as described in the documentation. I had to install it using the commit hash instead, as Xcode does not allow entering a four-integer version.

MikolajMichalczak commented 6 months ago

Thanks for the information @7-plus-t , and I understand. This version was an unexpected patch, and it's also crucial for Android wrapper versions to align with upcoming core library versions. We'll definitely take this into account for any future similar cases.