search

highcharts / highcharts-react-native

Other
103 stars 79 forks source link

setOptions source review please #84

Closed shinseon89 closed 4 years ago

shinseon89 commented 4 years ago

I think it should be changed as below to specify a setting value for the setOption property, can you review it?

before if (redraw) { Highcharts.setOptions('${setOptions}'); Highcharts.chart("container", ${this.serialize(this.props.options)}); }

after if (redraw) { Highcharts.setOptions(${this.serialize(setOptions)}); Highcharts.chart("container", ${this.serialize(this.props.options)}); }

pawelfus commented 4 years ago

Thanks for reporting the issue @shinseon89

FYI @sebastianbochan