enhancement/vue3-types - Githubissues

jszuminski commented 12 months ago

Fixed #209, added types for Vue 3.

Till now, the highcharts-vue.d.ts file included type declarations compatible with Vue 2, but not with Vue 3. The current solution splits the type definitions into 2 files (types/vue2/highcharts-vue.d.ts and types/vue3/highcharts-vue.d.ts) which are exported depending on the version of that the user has installed.

[x] add a type declaration file for Vue 3
[ ] test if the type declaration for Vue 3 throws any errors
[ ] test whether the proper type declaration file is exported depending on the version of Vue

rcheung9 commented 9 months ago

Is this going to be merged soon?

jszuminski commented 9 months ago

@rcheung9 the types/vue3/highcharts-vue.d.ts file is ready for Vue3, but we're trying to make the highcharts-vue work for all the versions combined and the problem we're analyzing here is how to generate a different .d.ts type definition file based on the version of Vue that the user is having in their project.

If there's no easy way to achieve that, we will probably publish a new version by the end of January which will support only Vue3 and will have only the type definition file compatible with Vue >2.

Do not hesitate to ask in case you have any Highcharts-related questions.

jszuminski commented 9 months ago

Closing as this problem will be covered by this pull request: https://github.com/highcharts/highcharts-vue/pull/258

highcharts / highcharts-vue

enhancement/vue3-types #251