Closed karolkolodziej closed 3 weeks ago
Sizes for compiled+gzipped (bold) and compiled files. | master | candidate | difference | |
---|---|---|---|---|
dashboards/dashboards.js | 43.1 kB 148.4 kB |
43.1 kB 148.4 kB |
11 B 41 B |
|
dashboards/modules/layout.js | 11.7 kB 45.8 kB |
11.7 kB 45.9 kB |
40 B 55 B |
Reference | Proposed | Diff | |
---|---|---|---|
performance – score | 1 | 1 | 0.00 |
first-contentful-paint – score | 1 | 1 | 0.00 |
first-contentful-paint – milliseconds | 230.07 | 189.25 | -40.82 |
first-meaningful-paint – score | 1 | 1 | 0.00 |
first-meaningful-paint – milliseconds | 451.08 | 437.64 | -13.44 |
dom-size – score | 1 | 1 | 0.00 |
dom-size – elements | 346 | 346 | 0.00 |
No differences found
Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff |
---|---|---|---|---|
2500000 | 0.16 | 0.16 | 0 | 1% |
Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff |
---|---|---|---|---|
2500000 | 16.32 | 15.79 | 0.52 | 3% |
Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff |
---|---|---|---|---|
2500000 | 745.75 | 742.54 | 3.21 | 0% |
Hm..... We are adding some new concepts/wording here (nested, standalone) in addition to new option. I feel it's perhaps to verbose. Not possible with a simpler approach? E.g.
editableOptions: [{
name: 'Component title',
propertyPath: ['title'],
type: 'input'
}, {
name: 'chartOptions',
children: [{
name: 'Marker Radius',
options: [{
name: 'Marker Radius',
propertyPath: [
'chartOptions',
'plotOptions',
'series',
'marker',
'radius'
],
type: 'select',
selectOptions: [{
name: 3
}, {
name: 5
}]
}]
}]
}
]
If the children
option doesn't exist it's standalone (the default). Isn't children a more common terminology for this concept, from a dev point of view? If feel standalone/nested calls for more explanation.
@stitot I'm fine with that but the only drawback is that with this approach it won't be possible to have collapsible singular elements like we used to have:
Hm...... From a UX (and perhaps a11y?) perspective it makes sense for me to have all these single values exposed. Takes more space, but easier to find the value you try to edit (by looking at actual value, not name of field) instead of expanding them to see what's hidden inside.
We could introduce an collapsed
option, that is false by default?
Added
isStandalone
option to add non-nested options in the edit mode sidebar, #20793.