search

highcharts / highcharts

Highcharts JS, the JavaScript charting framework
https://www.highcharts.com
Other
11.87k stars 3.54k forks source link

bugfix/16915-minPadding-navigator-ignored #21153

Closed K009 closed 1 week ago

K009 commented 1 month ago

Fixed #16915, the navigator should inherit the base x-axis padding when ordinal is false.

highsoft-bot commented 1 month ago

File size comparison

Sizes for compiled+gzipped (bold) and compiled files. master candidate difference
highstock.js 128.6 kB
371.9 kB		 128.6 kB
372.0 kB		 9 B
78 B
highcharts-gantt.js 133.8 kB
385.8 kB		 133.8 kB
385.9 kB		 11 B
78 B
modules/accessibility.js 37.4 kB
136.0 kB		 37.5 kB
136.1 kB		 14 B
78 B
highsoft-bot commented 1 month ago

Visual test results - Differences found

Found 6 diffing sample(s). Please review the differences.

highsoft-bot commented 1 month ago

Benchmark report - Stock

benchmarks/Stock/Stock-DataGrouping.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
1000000 1064.53 1095.48 -30.94 -3%
See all | Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff | | --- | --- | --- | --- | --- | | 1000 | 256.64 | 256.29 | 0.35 | 0% | 10000 | 268.31 | 268.06 | 0.25 | 0% | 100000 | 399.87 | 412.05 | -12.18 | -3% | 1000000 | 1064.53 | 1095.48 | -30.94 | -3%

benchmarks/Stock/Stock-Base.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
1000000 6362.13 6382.84 -20.71 0%
See all | Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff | | --- | --- | --- | --- | --- | | 1000 | 254.47 | 264.8 | -10.33 | -4% | 10000 | 352.99 | 356.22 | -3.23 | -1% | 100000 | 916.05 | 926.31 | -10.25 | -1% | 1000000 | 6362.13 | 6382.84 | -20.71 | 0%

benchmarks/Stock/Stock-DataGrouping-Ordinal.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
1000000 1452.65 1452.38 0.27 0%
See all | Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff | | --- | --- | --- | --- | --- | | 1000 | 266.41 | 271.9 | -5.49 | -2% | 10000 | 286.5 | 287.75 | -1.25 | 0% | 100000 | 500.11 | 503.65 | -3.54 | -1% | 1000000 | 1452.65 | 1452.38 | 0.27 | 0%

benchmarks/Stock/Stock-Ordinal.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
1000000 1449.73 1446.4 3.33 0%
See all | Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff | | --- | --- | --- | --- | --- | | 1000 | 266.83 | 264.67 | 2.16 | 1% | 10000 | 286.03 | 282.98 | 3.05 | 1% | 100000 | 497.31 | 506.47 | -9.16 | -2% | 1000000 | 1449.73 | 1446.4 | 3.33 | 0%
pawelfus commented 1 month ago

All visual diffs come from Standalone Nav, @bm64 could you please check it?