search

highcharts / highcharts

Highcharts JS, the JavaScript charting framework
https://www.highcharts.com
Other
11.86k stars 3.52k forks source link

dash/error-msg #21160

Closed karolkolodziej closed 1 week ago

karolkolodziej commented 2 weeks ago

Improved error messages when options were misconfigured, see #21091.

highsoft-bot commented 2 weeks ago

File size comparison

Sizes for compiled+gzipped (bold) and compiled files. master candidate difference
dashboards/dashboards.js 43.1 kB
148.4 kB		 43.1 kB
148.5 kB		 34 B
152 B
dashboards/modules/layout.js 11.7 kB
45.8 kB		 11.7 kB
45.8 kB		 16 B
19 B
highsoft-bot commented 2 weeks ago

Lighthouse report

dashboards-demo-minimal.json

Reference Proposed Diff
performance – score 1 1 0.00
first-contentful-paint – score 1 1 0.00
first-contentful-paint – milliseconds 219.75 188.14 -31.61
first-meaningful-paint – score 1 1 0.00
first-meaningful-paint – milliseconds 441.13 445.5 4.37
dom-size – score 1 1 0.00
dom-size – elements 346 346 0.00
highsoft-bot commented 2 weeks ago

Dashboard visual diffs

Visual differences found in:

highsoft-bot commented 2 weeks ago

Visual test results - No difference found

highsoft-bot commented 2 weeks ago

Benchmark report - Dashboards

benchmarks/Dashboards/DataTable-loading-rows.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 747.79 743.1 4.69 1%
See all | Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff | | --- | --- | --- | --- | --- | | 100 | 0.29 | 0.29 | 0 | 2% | 1000 | 0.52 | 0.53 | -0.01 | -2% | 10000 | 3.19 | 2.78 | 0.41 | 15% | 100000 | 16.55 | 16.2 | 0.35 | 2% | 1000000 | 287.29 | 291.03 | -3.74 | -1% | 2500000 | 747.79 | 743.1 | 4.69 | 1%

benchmarks/Dashboards/DataPool-CSV-constructor.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 0.17 0.17 0 1%
See all | Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff | | --- | --- | --- | --- | --- | | 100 | 0.17 | 0.16 | 0.01 | 3% | 1000 | 0.17 | 0.16 | 0 | 2% | 10000 | 0.16 | 0.17 | -0.01 | -3% | 100000 | 0.17 | 0.17 | 0 | 1% | 1000000 | 0.16 | 0.16 | 0 | 1% | 2500000 | 0.17 | 0.17 | 0 | 1%

benchmarks/Dashboards/DataTable-loading-columns.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 16.12 16.23 -0.11 -1%
See all | Sample size | This PR avg (ms) | master avg (ms) | Diff | Percent diff | | --- | --- | --- | --- | --- | | 100 | 0.24 | 0.24 | 0 | 2% | 1000 | 0.24 | 0.24 | 0 | 1% | 10000 | 0.28 | 0.28 | 0 | 0% | 100000 | 2.41 | 2.3 | 0.1 | 5% | 1000000 | 9.33 | 8.87 | 0.46 | 5% | 2500000 | 16.12 | 16.23 | -0.11 | -1%