search

highcharts / map-collection-dist

Other
29 stars 37 forks source link

Fix #32: Replace Hy?go (typo) region in Japan with Hyogo #128

Closed maor-refaeli closed 10 months ago

maor-refaeli commented 11 months ago

Issue https://github.com/highcharts/map-collection-dist/issues/32

maor-refaeli commented 11 months ago

Hey @jon-a-nygaard @KacperMadej @TorsteinHonsi , I made this small PR, please take a look if that is ok with you Thanks

TorsteinHonsi commented 10 months ago

Thanks @maor-refaeli

Unfortunately these files are generated, so your changes would probably be overwritten on the next release. @KacperMadej can we apply this to the sources?

KacperMadej commented 10 months ago

Applied a fix to the source using Hyōgo as the correction for Hy?go.

maor-refaeli commented 10 months ago

Thanks @KacperMadej and @TorsteinHonsi ! I guess map-collection is a private repo, so I don't have access to it. Can you share in a label or a comment in which version is this fix expected to be released? Also, please consider using Hyogo instead of Hyōgo to avoid accent mismatch (same as you don't have accents on all of Japan's regions)

KacperMadej commented 10 months ago

@maor-refaeli We will be using Hyogo instead of Hyōgo to avoid accent mismatch - thank you for pointing this out.

I guess map-collection is a private repo, so I don't have access to it.

The fix will be the same as commit.

Can you share in a label or a comment in which version is this fix expected to be released?

The next version should have this fix. That should be v2.1.1 unless there will be a need for a more significant version change for the next release. I will add additional comment here when I will know more (version and date).