search

highfidelity / hifi-docs-grav-content

Content repository for hifi-docs on Grav
4 stars 67 forks source link

New Marketplace Item Tester MVP docs for RC74. #318

Closed jennaingersoll closed 6 years ago

jennaingersoll commented 6 years ago

The images aren't appearing because I had to use html (rather than markdown) to get them formatted correctly. The directories are created automatically when Grav (our doc tool) processes the markdown files. I can confirm that they show up correctly on my test build. image

I recommend foregoing documentation in this release for the other points you made. I will expand upon the behavior in RC75 when I look at it again for the stretch goals.

kkurian commented 6 years ago

@ingerjm0 Understood. Since I have submitted my review I am apparently not allowed to submit another one unless you request it. Please do and I will.

jennaingersoll commented 6 years ago

@ingerjm0 Understood. Since I have submitted my review I am apparently not allowed to submit another one unless you request it. Please do and I will.

Just confirmed with Brad, you should still be able to approve? I am unable to "readd" you as a reviewer. If you go to Files Changed > Review changes, do you not have an option to approve?