highlight / highlight

highlight.io: The open source, full-stack monitoring platform. Error monitoring, session replay, logging, distributed tracing, and more.
https://app.highlight.io
Other
7.11k stars 320 forks source link

fix: Formatted network request payload has weird formatting #8603

Closed jemiluv8 closed 2 weeks ago

jemiluv8 commented 2 weeks ago

fixes #8560 /claim #8560

Summary

There was a class name conflict between two third party components

  1. react-command-pallette
  2. react-syntax-highlighter

The react-command-pallete library comes with a default theme called "atom" that has a declaration for "atom-input" This theme is imported whenever the react-command-pallete is used and was thus globally available.

Our graphql variable "Type" also has the class name atom-input and therefore inherits the global styling for the default atom theme from the react-command-pallete component.

My proposed solution just overrides those styles by introducing a global declaration with higher specificity that unsets the css declaration. I';ve seen similar done for the atom-overlay class.

Default atom style from the command-pallete library.

This is imported as a global css by the library.

Screenshot 2024-05-17 at 12 03 49 PM

Fixed output

Screenshot 2024-05-17 at 1 00 52 PM

How did you test this change?

Click testing

Are there any deployment considerations?

No

Does this work require review from our design team?

No

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: af1cdfb750dde273ddc1952b04bb55074885bc8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```